Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to struct datatype #26

Merged
merged 2 commits into from
Nov 7, 2023
Merged

feat: support to struct datatype #26

merged 2 commits into from
Nov 7, 2023

Conversation

WenyXu
Copy link
Collaborator

@WenyXu WenyXu commented Nov 5, 2023

Support to struct datatype

#14

@WenyXu WenyXu requested a review from Jefffrey November 5, 2023 11:24
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2023 •
edited
Loading

Codecov Report

Attention: 258 lines in your changes are missing coverage. Please review.

Comparison is base (995e0f3) 79.35% compared to head (b4828e4) 76.42%.
Report is 6 commits behind head on main.

❗ Current head b4828e4 differs from pull request most recent head feb932c. Consider uploading reports for the commit feb932c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   79.35%   76.42%   -2.93%     
==========================================
  Files          29       32       +3     
  Lines        2499     3211     +712     
==========================================
+ Hits         1983     2454     +471     
- Misses        516      757     +241
Flag Coverage Δ
rust 76.42% <75.19%> (-2.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/arrow_reader/column/binary.rs 88.88% <100.00%> (+1.38%) ⬆️
src/arrow_reader/column/boolean.rs 100.00% <100.00%> (ø)
src/arrow_reader/column/date.rs 92.30% <100.00%> (ø)
src/arrow_reader/column/float.rs 100.00% <100.00%> (ø)
src/arrow_reader/column/int.rs 100.00% <100.00%> (ø)
src/arrow_reader/column/present.rs 100.00% <100.00%> (ø)
src/arrow_reader/column/string.rs 97.36% <100.00%> (+2.13%) ⬆️
src/arrow_reader/column/timestamp.rs 90.00% <100.00%> (+0.81%) ⬆️
src/arrow_reader/column/tinyint.rs 100.00% <100.00%> (ø)
src/async_arrow_reader.rs 82.08% <100.00%> (+2.25%) ⬆️
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WenyXu WenyXu marked this pull request as draft November 5, 2023 11:49
Jefffrey
Jefffrey reviewed Nov 5, 2023
View reviewed changes
src/arrow_reader/column.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as ready for review November 5, 2023 13:33
@WenyXu WenyXu marked this pull request as draft November 5, 2023 14:58
@WenyXu WenyXu marked this pull request as ready for review November 5, 2023 16:32
@WenyXu WenyXu force-pushed the feat/struct branch 2 times, most recently from 546e96a to 38d5d89 Compare November 5, 2023 17:27
@waynexia waynexia mentioned this pull request Oct 30, 2024
Open
16 tasks
Jefffrey
Jefffrey approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Lots of changes but we can probably focus on getting functionality in first before then optimizing/refactoring later

src/arrow_reader.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu merged commit b641249 into datafusion-contrib:main Nov 7, 2023
6 checks passed
progval pushed a commit to progval/datafusion-orc that referenced this pull request Mar 6, 2024
@chmp
Merge pull request datafusion-contrib#26 from chmp/feature/release-notes
7460365 
Update changelog
waynexia pushed a commit that referenced this pull request Oct 24, 2024
@WenyXu
Merge pull request #26 from WenyXu/feat/struct
ea6fde9 
feat: support to struct datatype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefffrey Jefffrey Jefffrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenyXu @Jefffrey